Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: add BUNDLE DESTINATION to fix cross-build to iOS/watchOS/tvOS #177

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jul 8, 2021

BUNDLE DESTINATION is required for installation of executable target if cross-build to iOS/tvOS/watchOS, otherwise CMake configuration fails.

see https://cmake.org/cmake/help/latest/policy/CMP0006.html

required for installation of executable target if cross-build to iOS/tvOS/watchOS
see https://cmake.org/cmake/help/latest/policy/CMP0006.html
@google-cla
Copy link

google-cla bot commented Jul 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jul 8, 2021

@googlebot I signed it!

@gchatelet gchatelet merged commit 2939ece into google:master Oct 18, 2021
@SpaceIm SpaceIm deleted the fix/cmake-bundle branch October 18, 2021 11:37
@gchatelet gchatelet added this to the v0.7.0 milestone Mar 8, 2022
@gchatelet gchatelet added cmake CMake related issue bug Something isn't working labels Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmake CMake related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants