Skip to content

Commit

Permalink
infra: Disable coverage collection on armhf
Browse files Browse the repository at this point in the history
The armhf rustc is not compiled with profiling enabled.
See rust-lang/rust#79640

BUG=b:239255082
TEST=lucicfg validate

Change-Id: I65f66e1119f9560aea72fd00d8cc3427c1161525
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3831286
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Tested-by: Dennis Kempin <denniskempin@google.com>
  • Loading branch information
denniskempin committed Aug 15, 2022
1 parent 076476e commit 9ecd15f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion infra/config/generated/cr-buildbucket.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ buckets {
}
properties:
'{'
' "coverage": true,'
' "coverage": false,'
' "crosvm_direct": false,'
' "recipe": "build_linux",'
' "repeat_tests": 3,'
Expand Down
7 changes: 4 additions & 3 deletions infra/config/main.star
Original file line number Diff line number Diff line change
Expand Up @@ -238,12 +238,13 @@ def verify_builder(
cq_group = "main",
)

def verify_linux_builder(arch, crosvm_direct = False, **kwargs):
def verify_linux_builder(arch, crosvm_direct = False, coverage = True, **kwargs):
"""Creates a verify builder that builds crosvm on linux
Args:
arch: Architecture to build and test
crosvm_direct: Test crosvm-direct instead of crosvm
coverage: Disable coverage collection
**kwargs: Passed to verify_builder
"""
name = "linux_%s" % arch
Expand All @@ -264,7 +265,7 @@ def verify_linux_builder(arch, crosvm_direct = False, **kwargs):
},
postsubmit_properties = {
"repeat_tests": 3,
"coverage": True,
"coverage": coverage,
},
presubmit_properties = {
"retry_tests": 2,
Expand Down Expand Up @@ -336,7 +337,7 @@ def infra_builder(name, postsubmit, **args):
verify_linux_builder("x86_64")
verify_linux_builder("x86_64", crosvm_direct = True)
verify_linux_builder("aarch64")
verify_linux_builder("armhf")
verify_linux_builder("armhf", coverage = False)

verify_chromeos_builder("amd64-generic", presubmit = False)

Expand Down

0 comments on commit 9ecd15f

Please sign in to comment.