-
Notifications
You must be signed in to change notification settings - Fork 2k
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dagger-android-processor
still always enables formatting
#3531
Comments
Went ahead and made one in #3532 |
Thanks, I'll go ahead and patch in your PR and submit it. Unfortunately, our tooling is complex enough that it is easiest to just do it this way rather than have you actually submit the PR. You should be credited as the original author on the commit though. Thanks! |
Just updating for clarification, we actually decided to go another route and remove the formatting entirely since we don't format in Hilt and so adding a flag doesn't really feel worth it. |
Fixes #3531. RELNOTES=Remove formatting from dagger.android generated source. May be relevant for golden files. PiperOrigin-RevId: 468278501
Fixes #3531. RELNOTES=Remove formatting from dagger.android generated source. May be relevant for golden files. PiperOrigin-RevId: 468278501
This line does not respect the value of the formatting compiler option.
I can take a shot at a PR if you're open to it
The text was updated successfully, but these errors were encountered: