Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagger 2.50 produces code that calls deprecated method #4203

Closed
mar3kk opened this issue Jan 2, 2024 · 1 comment · Fixed by #4219
Closed

Dagger 2.50 produces code that calls deprecated method #4203

mar3kk opened this issue Jan 2, 2024 · 1 comment · Fixed by #4219

Comments

@mar3kk
Copy link

mar3kk commented Jan 2, 2024

Dagger 2.50 produces code that calls deprecated DoubleCheck.lazy(initializerProvider) method issuing warnings.

AmazonAdIntegration_Factory.java:49: warning: [deprecation] <P,T>lazy(P) in DoubleCheck has been deprecated
    return newInstance(splitInstallManagerProvider.get(), DoubleCheck.lazy(initializerProvider), dummyAdLoaderFactoryProvider.get(), dummyAdViewHolderFactoryProvider.get());
                                                                     ^
  where P,T are type-variables:
    P extends Provider<T> declared in method <P,T>lazy(P)
    T extends Object declared in method <P,T>lazy(P)
@Chang-Eric
Copy link
Member

Ah sorry about that, I added the @Deprecated there because it usually would indicate version skew between the generated Component and the Dagger runtime, but it looks like I forgot that the generated Factory classes can call that method as well. A future change is going to update the factory classes, but in the meantime, I'll remove the @Deprecated annotation on that for now.

copybara-service bot pushed a commit that referenced this issue Jan 18, 2024
… can still

be used by the factory classes. A future change will re-add this `@Deprecated` once the factory classes have been switched to use `dagger.internal.Provider`

Fixes #4203.

RELNOTES=Fixes #4203. Removes `@Deprecated` annotation causing warnings
PiperOrigin-RevId: 598930874
copybara-service bot pushed a commit that referenced this issue Jan 18, 2024
… can still

be used by the factory classes. A future change will re-add this `@Deprecated` once the factory classes have been switched to use `dagger.internal.Provider`

Fixes #4203.

RELNOTES=Fixes #4203. Removes `@Deprecated` annotation causing warnings
PiperOrigin-RevId: 598930874
copybara-service bot pushed a commit that referenced this issue Jan 19, 2024
… can still

be used by the factory classes. A future change will re-add this `@Deprecated` once the factory classes have been switched to use `dagger.internal.Provider`

Fixes #4203.

RELNOTES=Fixes #4203. Removes `@Deprecated` annotation causing warnings
PiperOrigin-RevId: 598930874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants