Suppress annotation on @Inject is not honored on the Factory

[BraisGabin]

I have a class that needs to inject a deprecated class. It looks like this:

public class Foo {
    @Inject
    @SuppressWarnings("deprecation")
    Foo(DeprecatedClass foo) {
    }
}

The generated Foo_Factory doesn't add the @SuppressWarning for "deprecation":

@ScopeMetadata
@QualifierMetadata
@DaggerGenerated
@Generated(
    value = "dagger.internal.codegen.ComponentProcessor",
    comments = "https://dagger.dev"
)
@SuppressWarnings({
    "unchecked",
    "rawtypes",
    "KotlinInternal",
    "KotlinInternalInJava",
    "cast"
})
public final class Foo_Factory implements Factory<Foo> {
  private final Provider<DeprecatedClass> fooProvider;

  public Foo_Factory(Provider<DeprecatedClass> fooProvider) {
    this.fooProvider = fooProvider;
  }
// ...

This prevents me to run java with -Werror active. I found that this feature exist on Hilt for other cases or at least that's what I understand from #2834.

---

Something similar happens when the deprecated class has the @Inject. The Factory also contains warning. Example:

@Deprecated("Don't use, please")
class DeprecatedClass @Inject constructor()

I found out this last one while writing this snippets for this issue so I don't care that much about it. And I'm not sure if it should be tracked in this issue or open a new one.

[Chang-Eric]

Thanks for letting us know. Unfortunately there isn't really a great way to decide when to copy this deprecation annotation over, as there isn't really a 1:1 correspondence since it isn't like we're copying a method or something. The deprecated usage in the constructor turns into needing to suppress it across the whole factory class. Presumably we'd also need to suppress it at the @Component level as well. So we ended up deciding to just always suppress this in all of our generated code since all of those usages should be coming from user code anyway (unless something really basic gets deprecated). I've submitted this change above.