Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for firefox indexeddb #53

Merged
merged 20 commits into from
Oct 29, 2024
Merged

Add support for firefox indexeddb #53

merged 20 commits into from
Oct 29, 2024

Conversation

sydp
Copy link
Collaborator

@sydp sydp commented Aug 24, 2024 •
edited
Loading

Fixes #3

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@sydp sydp marked this pull request as ready for review September 2, 2024 00:19
@sydp sydp requested a review from dfjxs October 28, 2024 00:27
dfjxs
dfjxs reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@dfjxs dfjxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some weird spacing in some places. Maybe the linter isn't set to pick that up?

dfindexeddb/indexeddb/cli.py Show resolved Hide resolved
dfindexeddb/indexeddb/cli.py Outdated Show resolved Hide resolved
@sydp sydp requested a review from dfjxs October 29, 2024 01:06
@sydp sydp merged commit 6a40f9a into google:main Oct 29, 2024
18 checks passed
@sydp sydp deleted the ffox branch October 29, 2024 01:53
@sydp sydp mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfjxs dfjxs dfjxs approved these changes

@aguilajesus aguilajesus Awaiting requested review from aguilajesus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Firefox format IndexedDb
2 participants
@sydp @dfjxs