New ups type #1000
New ups type #1000
Conversation
|
Hi, not sure on the best way to add units for battery_energy_capacity, units are ampere_hours but not sure whether this should be under energy density or under a new batterycapacity measurement |
cstirdivant
requested review from
shambergoldstein
and removed request for
tasodorff
cstirdivant
requested review from
cstirdivant
and removed request for
shambergoldstein
kevin-hereworks
force-pushed
the
new-ups-type
branch
2 times, most recently
from
1beecdf
to
931bb6d
Compare
| electriccharge: | ||
| milliampere_hours: STANDARD | ||
| ampere_hours: | ||
| multiplier: 1000 |
There was a problem hiding this comment.
Please revise this multiplier to convert from the standard unit of coulomb to whatever target unit you need.
| @@ -262,6 +262,7 @@ measurement: | |||
| angularmomentum: "The quantity of rotation of a body, which is the product of its moment of inertia and its angular velocity." | |||
| aqi: "Air quality index, a set of special standard gradings for the pollution in air." | |||
| area: "Amount of space within the perimeter of a 2D shape" | |||
| electriccharge: "Energy charge in a battery" | |||
There was a problem hiding this comment.
Please revise this to be more general. For example: "The amount of energy or electrons that pass from one body to another by different modes like conduction, induction or other specific methods (e.g., the charge stored in a battery)."
| @@ -106,6 +124,10 @@ PPWM: | |||
| guid: "aab62bba-a92f-47bf-bf14-dcb8e61ac7a8" | |||
| description: "Phase power monitoring" | |||
| is_abstract: true | |||
| opt_uses: | |||
There was a problem hiding this comment.
Please create a new type for these power fields (see METERS/PLPM for a good example)
There was a problem hiding this comment.
Do you want me to create a new type for just - phase1_power_sensor, - phase2_power_sensor, - phase3_power_sensor?
Or remove these from PPWM and make a copy of PLPM here?
The PLPM has the apparant power and the power fields in the meters
There was a problem hiding this comment.
Please create a new type in this file called PLPM and it only needs to have the three power_sensor fields as required (you can put the apparent_power fields and the line_frequency_sensor in the opt_uses section on the PLPM type).
| @@ -106,6 +124,10 @@ PPWM: | |||
| guid: "aab62bba-a92f-47bf-bf14-dcb8e61ac7a8" | |||
| description: "Phase power monitoring" | |||
| is_abstract: true | |||
| opt_uses: | |||
There was a problem hiding this comment.
Please create a new type in this file called PLPM and it only needs to have the three power_sensor fields as required (you can put the apparent_power fields and the line_frequency_sensor in the opt_uses section on the PLPM type).
| @@ -3129,6 +3129,10 @@ literals: | |||
| fixed_min: 0.0 | |||
| flexible_max: 2000.0 | |||
|
|
|||
| - electriccharge_sensor: | |||
| fixed_min: 0.0 | |||
| flexible_max: 10000.0 | |||
There was a problem hiding this comment.
These values need to be in the STANDARD units as defined in the units.yaml. I am assuming you need to convert this to coulombs.
No description provided.