Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spellcheck Ontology #1072

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Spellcheck Ontology #1072

merged 1 commit into from
Jul 18, 2023

Conversation

azenla
Copy link
Collaborator

@azenla azenla commented Jun 22, 2023

No description provided.

@azenla azenla changed the title Spellcheck Spellcheck Ontology Jun 22, 2023
@azenla azenla requested review from trav3711 and sypks June 26, 2023 18:14
trav3711
trav3711 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@trav3711 trav3711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that the spellcheck isn't using setuptools. We should probably deprecate that package from the other tools as well.

@trav3711 trav3711 self-requested a review July 17, 2023 15:40
trav3711
trav3711 suggested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@trav3711 trav3711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts.

@trav3711 trav3711 self-requested a review July 18, 2023 17:51
trav3711
trav3711 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@trav3711 trav3711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@trav3711 trav3711 merged commit d4087bd into google:master Jul 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trav3711 trav3711 trav3711 approved these changes

@sypks sypks Awaiting requested review from sypks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azenla @trav3711