Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new fan, fcu, and vav types, fields, subfields. #1270

Merged
merged 12 commits into from
Feb 15, 2024

Conversation

ccquigley
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@cstirdivant cstirdivant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see individual comments. Additionally, you need to add GUIDs to all new types

ontology/yaml/resources/HVAC/entity_types/FAN.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/VAV.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/VAV.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/subfields/subfields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved
@cstirdivant cstirdivant merged commit 20d0507 into google:master Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants