Added UPS battery remaining time #1292
Conversation
| @@ -83,3 +83,17 @@ UPS_SS_UPSBM: | |||
| - UPS | |||
| - SS | |||
| - UPSBM | |||
|
|
|||
| UPS_UPSBM: | |||
There was a problem hiding this comment.
You cannot name this canonical type using an abstract type you aren't implementing. You need to fully implement UPSBM instead. We want to avoid defining individual fields on a canonical type.
Based on the set of fields you have here, it seems like you'd want to implement UPSBM and IOBM
There was a problem hiding this comment.
is_canonical: false
I don't want to implement IOBM because it contains quite a few required fields that we don't have. UPSBM requires "remaining_charge_sensor", which we also don't have. I've created a field called "remaining_battery_time_sensor" that accurately reflects the data we do have.
There was a problem hiding this comment.
I've changed the type name to a non-canonical type name UPS_UPSTR
| @@ -2915,6 +2915,9 @@ literals: | |||
| - LOW | |||
| - MEDIUM | |||
| - HIGH | |||
| - remaining_battery_time_sensor: | |||
There was a problem hiding this comment.
use existing field remaining_charge_time_sensor instead
There was a problem hiding this comment.
Does "remaining_charge_time_sensor" indicate the amount of time remaining until the battery is fully charged, or the amount of time remaining until the battery is fully discharged? I took it to mean the former, which leaves an important value out of the ontology, being the amount of time the UPS will continue to power the given load in battery mode.
|
Hi @briancjohns I cannot review this until it only contains yaml files within the ontology/ folder. Please ensure you are committing from within the ontology/ folder |
No description provided.