New devices HDS, WSR, etc #794
Conversation
|
@josephedwardchang could you please check on this PR? a few ontology validator failures due to the apparent_power adjustment, and a few comments that you mention are resolved but i still see in their previous form. please push your latest updates and pass the validator and we can get this wrapped up. |
|
@tasodorff @josephedwardchang can you please resolve the conflicts |
| - FSS | ||
| - FA2X | ||
| uses: | ||
| - failed_panel_alarm |
There was a problem hiding this comment.
I suggest using master_alarm to model this catch-all alarm
| - high_zone_air_h2_concentration_alarm: | ||
| - ACTIVE | ||
| - INACTIVE | ||
| - gas_release_status: |
There was a problem hiding this comment.
Is this a status (feedback) or should it be a command ?
There was a problem hiding this comment.
this is status, ma'am, the BMS has no controls for all fire systems (just alarms). the fire controls are automated, split apart from the BMS.
There was a problem hiding this comment.
Is it correct to call this a gas_release_valve_status ?
There was a problem hiding this comment.
Yes ma'am possibly better. I'll update now
| - damper_status | ||
| - damper_command | ||
|
|
||
| ASD: |
There was a problem hiding this comment.
Ok that makes sense. I Notice here this type only has opt_uses (which is not best-practice). In this case, I suggest deleting the ASD type completely and simply defining these fields on the FACP_ASD type directly
|
Hi All, We have pending validation on the site and we would like to get this pull request to be merged as the project needs to be closed and I'm afraid this merge is required. Thanks |
| - high_zone_air_h2_concentration_alarm: | ||
| - ACTIVE | ||
| - INACTIVE | ||
| - gas_release_status: |
There was a problem hiding this comment.
Is it correct to call this a gas_release_valve_status ?
cstirdivant
dismissed
tasodorff’s stale review
requested changes have been addressed
new devices:
HDS - hydrogen sensor with alarm
WSR - water softener
WCR - water conditioner
EHT - heat tracer
EHT_SS and EHT_SS_ALM - new canonicals for EHT
FCU_RHDHS_DTM_DFSS_STM_DTC_SHM_SFVSC_ALM_SS_SRC - new canonical FCU
UPS_SS_ALM - new canonical UPS