Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of a new canonical Chiller. #886

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Addition of a new canonical Chiller. #886

merged 5 commits into from
Jul 10, 2023

Conversation

ghairapetian
Copy link
Contributor

No description provided.

@charbull charbull added the ontology model Extensions or edits to the ontology model label Jan 17, 2023
tasodorff
tasodorff previously approved these changes Jan 24, 2023
View reviewed changes
@cstirdivant
Copy link
Collaborator

@tasodorff is this redundant with the existence of CH_SS_SWTC? If it truly is an air-cooled chiller no need to use SCHWTC

@ghairapetian
Copy link
Contributor Author

@tasodorff is this redundant with the existence of CH_SS_SWTC? If it truly is an air-cooled chiller no need to use SCHWTC

It's truly an air cooled chiller. However, SWTC do not specify a cooling_percentage_command. I can add it as an optional field if you confirm.

@mschulze17
Copy link
Collaborator

@tasodorff can you PTAL?

@mschulze17 mschulze17 assigned tasodorff and unassigned cstirdivant Feb 22, 2023
@tasodorff
Copy link
Collaborator

Please add it as an optional field to SWTC and then you may proceed with using the existing CH_SS_SWTC type.

@tasodorff tasodorff assigned ghairapetian and unassigned tasodorff Mar 10, 2023
tasodorff
tasodorff previously requested changes Mar 10, 2023
View reviewed changes
ontology/yaml/resources/HVAC/entity_types/CH.yaml Outdated Show resolved Hide resolved
@charbull
Copy link
Collaborator

@ghairapetian friendly ping

@ghairapetian
Copy link
Contributor Author

@charbull , I made the correction requested. If it's not enough or wrong, do not hesitate.

@mschulze17 mschulze17 added the P2 Medium priority (default) label Apr 5, 2023
@mschulze17 mschulze17 assigned tasodorff and unassigned ghairapetian Apr 5, 2023
@cstirdivant cstirdivant assigned cstirdivant and unassigned tasodorff Jul 6, 2023
@cstirdivant cstirdivant dismissed tasodorff’s stale review July 6, 2023 16:33

All requested changes have been implemented

@cstirdivant cstirdivant requested review from cstirdivant and removed request for tasodorff July 6, 2023 16:34
@cstirdivant cstirdivant added ready to merge Ready to merge (pending back-end synchronization) and removed ontology model Extensions or edits to the ontology model labels Jul 6, 2023
@shambergoldstein shambergoldstein merged commit 6482fb1 into google:master Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstirdivant cstirdivant cstirdivant approved these changes

@tasodorff tasodorff tasodorff left review comments

Assignees

@cstirdivant cstirdivant

Labels
P2 Medium priority (default) ready to merge Ready to merge (pending back-end synchronization)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ghairapetian @cstirdivant @mschulze17 @tasodorff @charbull @shambergoldstein