Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of a new canonical CU type. #924

Merged
merged 8 commits into from
Jul 24, 2023

Conversation

ghairapetian
Copy link
Contributor

No description provided.

Copy link
Collaborator

@tasodorff tasodorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm this matches the definition for a CU.

ontology/yaml/resources/HVAC/entity_types/CU.yaml Outdated Show resolved Hide resolved
@tasodorff tasodorff assigned ghairapetian and unassigned tasodorff Mar 9, 2023
@charbull
Copy link
Collaborator

@tasodorff @ghairapetian any updates on this ?

@mschulze17 mschulze17 added the P2 Medium priority (default) label Apr 5, 2023
@mschulze17 mschulze17 assigned tasodorff and unassigned ghairapetian Apr 5, 2023
@cstirdivant cstirdivant dismissed tasodorff’s stale review July 17, 2023 16:49

Comments have been addressed

@cstirdivant cstirdivant added the ready to merge Ready to merge (pending back-end synchronization) label Jul 17, 2023
@shambergoldstein shambergoldstein merged commit 7bca548 into google:master Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority (default) ready to merge Ready to merge (pending back-end synchronization)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants