-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions: deployment to GitHub Pages, link check #198
base: main
Are you sure you want to change the base?
Conversation
0e66e5a
to
25aeb03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, and it was never my intention to deploy the example site twice. My motivation for this PR is different: in the user guide we recommend using this repo as template when building a new site. We cannot assume, that all users host their site at netlify, some may opt for site hosting GitHub Pages. The Github Pages deployment workflow was added in order to make it as easy as possible for latter users to get their site deployed. We easily can (and should!) disable this workflow once my PR was merged. To sum up, this workflow has sample/demonstration character only and was never meant to be used for the actual deployment of the example site. WDYT? |
What if we moved these files from |
25aeb03
to
5a57839
Compare
* added workflow files * README.md: - added section on deployment via GitHub pages - added section on automated link checking
5a57839
to
8ad0273
Compare
This PR follows up and closes #161.
It adds automated workflows for
For this purpose, two workflow files for GitHub actions were added.
Workflow actions can be either run manually (via GitHub web UI) or on each push and/or pull request.
Two sections were added to README.md, describing the newly available features and their configuration.
Note:: In order to allow the workflow to cache npm dependencies,
packages.json.lock
was added to the repo.