Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: directory rename (avoid mixed case and spaces), and front matter cleanup #235

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Jul 30, 2023

As already pointed out in an docsy issue, we should avoid mixed-case directory names and names containing spaces for content sections. The docsy example has such sections, too. This PR corrects this.

@deining deining requested a review from chalin July 30, 2023 18:20
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin chalin changed the title content folders: rename mixed-case directory names and names containing spaces Content: directory rename (avoid mixed case and spaces), and front matter cleanup Nov 10, 2023
@chalin chalin merged commit 4a9d267 into google:main Nov 10, 2023
5 checks passed
@deining
Copy link
Collaborator Author

deining commented Nov 10, 2023

Glad to see this merged, but ...

It came to my mind that we still do have PR #241 which brings in the Chinese translation to the example site. In case we want to consider this PR, we should have brought this PR in prior to changing the folder names and file names ad done with this just merged PR. If we leave it as is, a lot of rework is required for the translation PR, I guess. WDYT?

@chalin
Copy link
Collaborator

chalin commented Nov 10, 2023

The two PRs have mutually exclusive content so the order doesn't matter IMHO. Can I let you inform the PR author of the changes that will be required (which don't seem to be too extensive)? Then again, I'm not convinced that we want another example language. Let's discuss this further in:

Maybe it's best just to let the author know that we're assessing the PR, but that if it's accepted it will need to conform to the new directory structure and names.

@deining deining deleted the folder-structure branch November 10, 2023 20:54
@deining
Copy link
Collaborator Author

deining commented Nov 10, 2023

Maybe it's best just to let the author know that we're assessing the PR, but that if it's accepted it will need to conform to the new directory structure and names.

Agreed. Let's wait for the decision of PSC.

chalin added a commit that referenced this pull request May 9, 2024
I believe that this empty file was introduced by mistake via:

- #235

WDYT @deining?
chalin added a commit that referenced this pull request May 16, 2024
I believe that this empty file was introduced by mistake via:

- #235

WDYT @deining?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants