-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content: directory rename (avoid mixed case and spaces), and front matter cleanup #235
Conversation
5621db1
to
d83d0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Glad to see this merged, but ... It came to my mind that we still do have PR #241 which brings in the Chinese translation to the example site. In case we want to consider this PR, we should have brought this PR in prior to changing the folder names and file names ad done with this just merged PR. If we leave it as is, a lot of rework is required for the translation PR, I guess. WDYT? |
The two PRs have mutually exclusive content so the order doesn't matter IMHO. Can I let you inform the PR author of the changes that will be required (which don't seem to be too extensive)? Then again, I'm not convinced that we want another example language. Let's discuss this further in: Maybe it's best just to let the author know that we're assessing the PR, but that if it's accepted it will need to conform to the new directory structure and names. |
Agreed. Let's wait for the decision of PSC. |
As already pointed out in an docsy issue, we should avoid mixed-case directory names and names containing spaces for content sections. The docsy example has such sections, too. This PR corrects this.