Skip to content

Commit

Permalink
removes text-uppercase class from nav title
Browse files Browse the repository at this point in the history
  • Loading branch information
@ritikbheda
ritikbheda committed Dec 7, 2021
1 parent 7dc7083 commit 9e1807b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion layouts/partials/navbar.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{{ $cover := and (.HasShortcode "blocks/cover") (not .Site.Params.ui.navbar_translucent_over_cover_disable) }}
<nav class="js-navbar-scroll navbar navbar-expand navbar-dark {{ if $cover}} td-navbar-cover {{ end }}flex-column flex-md-row td-navbar">
<a class="navbar-brand" href="{{ .Site.Home.RelPermalink }}">
<span class="navbar-logo">{{ if .Site.Params.ui.navbar_logo }}{{ with resources.Get "icons/logo.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}{{ end }}</span><span class="text-uppercase font-weight-bold">{{ .Site.Title }}</span>

This comment has been minimized.

Sign in to view

Copy link
@chalin

chalin Dec 21, 2021

Collaborator

Btw, @LisaFC & @emckean, this feels to me like a breaking style change, and a subtle one to catch at that. WDYT? Maybe we should start implementing a CHANGELOG sooner than later.

This comment has been minimized.

Sign in to view

Copy link
@chalin

chalin Dec 21, 2021

Collaborator

FWIW, I agree that this kind of styling shouldn't be hard coded in the HTML (#783), but this issue could/(should?) have been fixed in a backwards compatible way by using a semantically meaningful class name.

This comment has been minimized.

Sign in to view

Copy link
@emckean

emckean Jan 19, 2022

Collaborator

I agree, this should be done w/classes, and it seems breaking to me (and the kind of change that would make me doubt my sanity, at that ... "I could have SWORN this title was uppercase")

Maybe this is one of the things the visual regression testing will catch
<span class="navbar-logo">{{ if .Site.Params.ui.navbar_logo }}{{ with resources.Get "icons/logo.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}{{ end }}</span><span class="font-weight-bold">{{ .Site.Title }}</span>
</a>
<div class="td-navbar-nav-scroll ml-md-auto" id="main_navbar">
<ul class="navbar-nav mt-2 mt-lg-0">
Expand Down

0 comments on commit 9e1807b

Please sign in to comment.