Use SCSS join() rather than prepend() (#1736)

google · Nov 13, 2023 · e6c28d3 · e6c28d3
1 parent 889cd68
commit e6c28d3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,10 +24,15 @@ For the full list of changes, see the [release][0.8.0] notes.
 
 **Breaking changes**:
 
+- SCSS: `@function prepend()` and file `assets/scss/support/_functions.scss`
+  have been dropped. Instead use the more general SASS/SCSS list `join()`
+  function ([#1385]).
+
 **New**:
 
 **Other changes**:
 
+[#1385]: https://github.com/google/docsy/issues/1385
 [0.8.0]: https://github.com/google/docsy/releases/v0.8.0/#FIXME
 
 ## 0.7.2

diff --git a/assets/scss/_variables.scss b/assets/scss/_variables.scss
@@ -52,7 +52,7 @@ $td-fonts-serif: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto,
   "Segoe UI Symbol";
 
 @if $td-enable-google-fonts {
-  $td-fonts-serif: prepend($td-fonts-serif, "#{$google_font_name}");
+  $td-fonts-serif: join("#{$google_font_name}", $td-fonts-serif);
 }
 
 $font-family-sans-serif: $td-fonts-serif !default; // TODO: consider moving into UG SCSS or namespace the var (td-)

diff --git a/assets/scss/main.scss b/assets/scss/main.scss
@@ -1,6 +1,5 @@
 @import "../vendor/bootstrap/scss/functions";
 
-@import "support/functions";
 @import "_variables_forward";
 @import "variables_project";
 @import "variables";

diff --git a/assets/scss/support/_functions.scss b/assets/scss/support/_functions.scss