Foldable nav behavior changes as of Hugo 0.100.0

[chalin]

Visit a section with children and prior to Hugo 0.100.0 and you'll see the section entry open (with children visible) in the left nav. After 0.100.0, the same left-nav entry isn't open. For example, compare the state of the left-nav for the following two preview builds:

• https://deploy-preview-1476--opentelemetry.netlify.app/docs/instrumentation/js/api/ - uses Hugo 0.98
• https://deploy-preview-1477--opentelemetry.netlify.app/docs/instrumentation/js/api/ - uses Hugo 0.100.2 I've updated the PR so the problem no longer appears. I've included below a screenshot illustrating the original problem.

In particular, I'm guessing that we're being hit by the following:

• IsDescendant/IsAncestor returns true for self gohugoio/hugo#9925
• Fix HasMenuCurrent and IsDescendant/IsAncestor when comparing to itself gohugoio/hugo#9926

The resources above suggests a means of preserving the old behavior (which we may or may not want to do).

Related:

• 0.100.0 release notes.

Screenshots

Hugo 0.98

Hugo 0.100.2

[raum51]

I had only time for a short look at this issue:

• The problem is the not set CSS class "active-path" for die li tags along the current page path.
• I think we have to redesign line 45 in the sidebar-tree.html partial:

  docsy/layouts/partials/sidebar-tree.html

  Line 45 in 9f55cf3

  {{ $activePath := and (not $shouldDelayActive) ($p.IsDescendant $s) -}}

Also possible side effects to the JS it the cached sidebar tree version should get checkt:

docsy/layouts/partials/sidebar.html

Lines 7 to 19 in 9f55cf3

	<script>
	$(function() {
	$("#td-section-nav a").removeClass("active");
	$("#td-section-nav #{{ $mid }}").addClass("active");
	$("#td-section-nav #{{ $mid }}-li span").addClass("td-sidebar-nav-active-item");
	$("#td-section-nav #{{ $mid }}").parents("li").addClass("active-path");
	$("#td-section-nav li.active-path").addClass("show");
	$("#td-section-nav li.active-path").children("input").prop('checked', true);
	$("#td-section-nav #{{ $mid }}-li").siblings("li").addClass("show");
	$("#td-section-nav #{{ $mid }}-li").children("ul").children("li").addClass("show");
	$("#td-sidebar-menu").toggleClass("d-none");
	});
	</script>

--> After a quick check, I think, the cached version should work fine.

I'm afraid, that I won't find the time to fix it and test it in the 1-2 weeks. So If anybody else can find time, it would be fine. If not, I have a time slot at the beginning of July, where I will update our own Docsy site.

[chalin]

@raum51 - Right. No worries, I have a fix (see open-telemetry/opentelemetry.io#1477), which I'll port this week (and you'll be welcome to comment on if you have the time).

[chalin]

/cc @nate-double-u