Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hugo 0.100.2 + Docsy patch #1477

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 23, 2022

In upgrading to Hugo 0.100.2, we were hitting the following issue:


Update: I've patched docsy, fixing 1065 in this PR by providing a file override. (I'll upstream the change as soon as I can.)

Other changes in the generated site files:

  • Page meta data:
    • Descriptions are different in whitespaces
    • Word counts differ (even if the page content hasnt' changed)
  • No other diffs that I'm aware of:

Note that the diff below is done over normalized pages that ignore the page header content up until the link to main.css (and the generator version number):

$ cd public && git diff -bw --ignore-blank-lines -I "Hugo 0." -- . ':(exclude)*.[^h]*'      
$

@chalin chalin requested a review from a team as a code owner June 23, 2022 15:36
@chalin chalin marked this pull request as draft June 23, 2022 15:42
@chalin chalin changed the title Upgrade to Hugo 0.100.2 Upgrade to Hugo 0.100.2 + Docsy patch Jun 23, 2022
@chalin chalin marked this pull request as ready for review June 23, 2022 20:46
@chalin
Copy link
Contributor Author

chalin commented Jun 23, 2022

/cc @nate-double-u ... in case you know of other CNCF project hitting this issue.

@chalin chalin merged commit 43aa068 into open-telemetry:main Jun 23, 2022
@chalin chalin deleted the chalin-im-hugo-0.100.2-2022-06-23 branch June 23, 2022 20:54
@chalin chalin added the CI/infra CI & infrastructure label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant