Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog pages should contain page-meta-lastmod.html too #1196

Closed
Tracked by #1789
chalin opened this issue Aug 23, 2022 · 2 comments · Fixed by #1791
Closed
Tracked by #1789

Blog pages should contain page-meta-lastmod.html too #1196

chalin opened this issue Aug 23, 2022 · 2 comments · Fixed by #1791
Assignees
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 23, 2022

@LisaFC et all: are you aware of any reason why blog pages don't contain "last mod" info like regular doc pages do?

Some context:

If there's no reason that you're aware of to omit that info at the bottom of the page, I suggest that we add it. Thoughts?

@chalin
Copy link
Collaborator Author

chalin commented Aug 23, 2022

I've quickly experimented with this and it looks best if we end the <div> in https://github.com/google/docsy/blob/main/layouts/blog/content.html with page-meta-lastmod.html last:

{{ partial "pager.html" . }}
{{ partial "page-meta-lastmod.html" . }}

For example:

image

@LisaFC
Copy link
Collaborator

LisaFC commented Sep 13, 2022

Happy to add it if you think it's useful - I think the main reason we didn't was that blog posts tend not to be updated (unless someone discovers an error post-publication) and have a publication date already. If they're being regularly updated they probably have content that should be in regular user docs. :)

Can't remember the issue/PR I commented on but I also think we should probably have a different "page meta links" for blog posts as most projects probably don't want to be inviting other users to edit guest blog posts. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants