Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo-links page-meta class names #1819

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Feb 2, 2024

  • Class names to disable [repository links] were misnamed with a suffix of the form --KIND. The new suffix is __KIND. I noticed the misnaming while working on Blog pages should contain page-meta-lastmod.html too #1196
  • Fixing sooner is better than later.
  • The old class names will still work but are deprecated

Preview: https://deploy-preview-1819--docsydocs.netlify.app/docs/adding-content/repository-links/#disabling-links

@chalin chalin mentioned this pull request Feb 2, 2024
33 tasks
@chalin chalin force-pushed the chalin-im-page-meta-class-name-fix-2024-02-02 branch from 205cfab to 7239c5c Compare February 2, 2024 18:42
@chalin chalin requested a review from LisaFC February 2, 2024 18:42
@chalin chalin force-pushed the chalin-im-page-meta-class-name-fix-2024-02-02 branch from 7239c5c to 39b95e7 Compare February 7, 2024 09:08
@chalin
Copy link
Collaborator Author

chalin commented Feb 7, 2024

Merging. Feedback is still welcome.

@chalin chalin merged commit 797b16d into google:main Feb 7, 2024
11 checks passed
@chalin chalin deleted the chalin-im-page-meta-class-name-fix-2024-02-02 branch February 7, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant