Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page feedback shouldn't require that a Google Analytics ID be set as a config parameter #1311

Closed
Tracked by #1667
chalin opened this issue Nov 14, 2022 · 5 comments · Fixed by #1727
Closed
Tracked by #1667
Assignees
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Nov 14, 2022

Google Analytics isn't always enabled via Docsy config -- for example, see:

For such projects, that want to use the page-feedback feature, they should be able to enable page-feedback without having to supply a bogus analytics ID. WDYT @LisaFC @emckean @geriom?

@LisaFC
Copy link
Collaborator

LisaFC commented Nov 14, 2022

So at the moment the only way to track the results of the page feedback feature is using Analytics - presumably users could hook their own mechanism in there but we'd need to mention that explicitly.

@emckean
Copy link
Collaborator

emckean commented Nov 14, 2022 via email

@chalin
Copy link
Collaborator Author

chalin commented Nov 14, 2022

To clarify: the projects I referred to are using Google Analytics (GA). It's just that GA isn't set up via Docsy -- it's set up via Netlify snippet injection. So GA is still active, but Docsy doesn't know about it. They way I've kept the page-feedback active is by supplying a bogus GA ID, but I'd rather avoid that if possible.

@emckean
Copy link
Collaborator

emckean commented Nov 14, 2022 via email

@chalin
Copy link
Collaborator Author

chalin commented Nov 21, 2022

There are a number of advantages, which I hope to share here (or during the next PSC meeting I"m able to attend) soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants