Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop / inline prepend() SCSS function #1385

Closed
Tracked by #1510 ...
chalin opened this issue Jan 31, 2023 · 1 comment · Fixed by #1736
Closed
Tracked by #1510 ...

Drop / inline prepend() SCSS function #1385

chalin opened this issue Jan 31, 2023 · 1 comment · Fixed by #1736
Labels
breaking change cleanup/refactoring design/style Front-end site design / styling e0-minutes Effort < 60 min
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Jan 31, 2023

Consider dropping prepend(), in favor of using join() directly:

@function prepend($list, $value) {
@return join($value, $list);
}

In doing so we can eliminate https://github.com/google/docsy/blob/main/assets/scss/support/_functions.scss.

AFAICT, there is only one instance of the call to prepend() in Docsy SCSS.

The other function that was in this file (color-diff()) was removed by:

@mahi072
Copy link

mahi072 commented Mar 2, 2023

Hi @chalin,
I would like to work on this issue

@chalin chalin mentioned this issue May 4, 2023
14 tasks
@chalin chalin added this to the 23Q4 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change cleanup/refactoring design/style Front-end site design / styling e0-minutes Effort < 60 min
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants