Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] replace lighten() by tint-color(), and var/func clean up #1384

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jan 31, 2023

Draw.io edit-button screenshot

Screen Shot 2023-01-31 at 10 12 48

- Drops $primary-light (breaking change)
- Drops `color-diff()` (breaking change)
- Replaces custom coloring of Draw.io edit button by outline-primary
@LisaFC
Copy link
Collaborator

LisaFC commented Jan 31, 2023

I think the button change is fine, I can't imagine anyone's look and feel being absolutely wedded to having a red edit button, and the new version will match the surrounding site.

Have we checked any of our contributed examples for those elements?

@chalin
Copy link
Collaborator Author

chalin commented Jan 31, 2023

Have we checked any of our contributed examples for those elements?

I've sampled the projects listed under Examples and none use these two SCSS elements. Of course, any project that might happen to use these elements can define their own after this PR is merged -- e.g., by copying the definitions that Docsy gave. The point that we're making here in dropping these elements is to recognize that they aren't a necessary part of Docsy (they weren't even mentioned in the User Guide).

@chalin
Copy link
Collaborator Author

chalin commented Jan 31, 2023

Oops, I had forgotten to commit the removal of color-diff(). Done now.

@chalin chalin merged commit c8530e3 into google:main Jan 31, 2023
@chalin chalin deleted the chalin-im-bsv5-color-migration-2023-01-31 branch January 31, 2023 21:41
@chalin
Copy link
Collaborator Author

chalin commented Jan 31, 2023

Possible followup:

@chalin chalin changed the title [BSv5] replace lighten by tint-color, and var/func clean up [BSv5] replace lighten() by tint-color(), and var/func clean up Jan 31, 2023
@chalin chalin mentioned this pull request Jan 31, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants