Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page-meta spacing is off for some pages #1573

Closed
Tracked by #1666
chalin opened this issue Jun 15, 2023 · 3 comments · Fixed by #1661
Closed
Tracked by #1666

Page-meta spacing is off for some pages #1573

chalin opened this issue Jun 15, 2023 · 3 comments · Fixed by #1661
Assignees
Labels
bug Something isn't working design/style Front-end site design / styling
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Jun 15, 2023

The screenshots below are from https://deploy-preview-1567--docsydocs.netlify.app/blog/.

Notice the spacing between the top nav and the page-meta links like View page source:

image

The spacing is off for selected pages like this:

Screen Shot 2023-06-15 at 19 03 19
@chalin chalin added bug Something isn't working design/style Front-end site design / styling labels Jun 15, 2023
@thequailman
Copy link

I solved this by adding:

main {
  min-height: 100vh;
}

Seems like a hack though, but the style of the layout is pretty bad to begin with. Should replace all of it with a grid.

@chalin
Copy link
Collaborator Author

chalin commented Nov 9, 2023

I believe that

Fixed the problem, by ensuring that the height of the left-nav is properly computed.

As a demonstration of the problem, see preview of the last PR just before before the #1661: https://deploy-preview-1668--docsydocs.netlify.app/blog/.

If you make the page tall enough, you'll see the mis-formatting of the toc, like this:

image

Now make the window shorter and eventually the toc formatting issue disappears on its own:

image

Since #1661, I can no longer reproduce the problem in that way! \o/

@chalin
Copy link
Collaborator Author

chalin commented Nov 9, 2023

Until proven otherwise, I'm going to assume that this was closed by:

@chalin chalin closed this as completed Nov 9, 2023
@chalin chalin mentioned this issue Nov 9, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design/style Front-end site design / styling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants