Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog list layout: no need for row/col-12 grid styling of content #1572

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jun 15, 2023


It is a bit hard to see, but there are no content changes in the layout other than:

  • Replacing <div class="row"><div class="col-12">{{ if .Pages -}}...</div></div> by
    <div class="td-blog-posts">{{ if .Pages -}}...</div>
  • And similarly replacing the divs for the pagination
  • Change from <h2> to <div class="h2"> of the post-list header

Note that the class names td-blog-posts* currently have not styles associated with them.

In the before and after images, note the following fixes:

  • The RSS button is flush-right and no longer takes up a column's worth of space
  • Spacing above the View page source page-meta buttons

Before

image

After

image

Showing the pagination buttons:

image

@chalin chalin requested review from deining and geriom June 15, 2023 19:26
@deining
Copy link
Collaborator

deining commented Jun 15, 2023

As seen in the preview, the spacing above the View page source buttons is not fixed by this PR. I tried locally too, both with chrome and firefox and I'm always getting the same, deficient result.

@chalin
Copy link
Collaborator Author

chalin commented Jun 15, 2023

Thanks for noticing that. I had only looked at the build of the example site -- it is strange that the page-meta spacing would be fixed there. I've stuck out that item from the opening comment -- it wasn't the original issue targeted by this PR. I can track the page-meta issue separately:

Any other comments @deining?

Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the spacing issue moved out of #1573, this PR looks good to me now.

@chalin chalin merged commit f75e689 into google:main Jun 16, 2023
6 checks passed
@chalin chalin deleted the chalin-im-blog-no-row-col-for-content-2023-06-15 branch June 16, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BSv5] Blog posts page has layout issues
2 participants