Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate tab-persistence key 'lang' not detected #1634

Closed
Tracked by #1641
deining opened this issue Jul 30, 2023 · 1 comment · Fixed by #1638
Closed
Tracked by #1641

Duplicate tab-persistence key 'lang' not detected #1634

deining opened this issue Jul 30, 2023 · 1 comment · Fixed by #1638
Assignees
Labels
regression Feature that has worked before stopped working
Milestone

Comments

@deining
Copy link
Collaborator

deining commented Jul 30, 2023

Minimum reproducible example:

{{< tabpane >}}
{{< tab lang="en" >}}
foo
{{< /tab >}}
{{< tab lang="en" >}}
bar
{{< /tab >}}
{{< /tabpane >}}

This works flawlessly with latest release version v0.7.1. A warning is emitted during run:

WARN  Shortcode "tabpane": duplicate language "en" detected, disabling persistance of language to avoid multiple tab display. Position: ....

With HEAD of repo, tabs are frozen, you cannot switch between the two tabs. There is no warning about duplicate persistence keys emitted any more.

@chalin: you worked on the tabpane shortcode lately. Can you have a look what's going wrong here? Thanks.

@deining deining added the regression Feature that has worked before stopped working label Jul 30, 2023
@deining deining added this to the 23Q3 milestone Jul 30, 2023
@chalin
Copy link
Collaborator

chalin commented Aug 2, 2023

Hmm, it works for me locally when building from HEAD, i.e.:

  • The tabs are not frozen
  • There is no issue with multiple tabs being selected
image

Let me investigate further.

@chalin chalin changed the title Regression: shortcode does not detect duplicate tab-persistence key 'lang' Duplicate tab-persistence key 'lang' not detected Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Feature that has worked before stopped working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants