Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabpane: fix duplicate-key detection #1638

Merged
merged 1 commit into from
Aug 2, 2023
Merged

tabpane: fix duplicate-key detection #1638

merged 1 commit into from
Aug 2, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Aug 2, 2023

@chalin chalin requested review from deining and geriom August 2, 2023 13:34
deining
deining approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your prompt reaction, the submitted PR fixes the problem.

@chalin chalin merged commit 3f3172a into google:main Aug 2, 2023
5 checks passed
@chalin chalin deleted the chalin-im-tabpane-key-fix-2023-08-02 branch August 2, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deining deining deining approved these changes

@geriom geriom Awaiting requested review from geriom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate tab-persistence key 'lang' not detected
2 participants
@chalin @deining