-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n of page feedback #175
Labels
Comments
Oh I really like this - this will be very useful for other Docsy users! Please do submit a PR. |
Note that there exist downstream implementations, such as the following:
I'm sure that there are others, I just happened to come across these ones. |
9 tasks
@cjyabraham - support has just landed in Docsy (FYI) /cc @nate-double-u |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Currently the
feedback.html
partial is not internationalized as the values are hardcoded into English.docsy/layouts/partials/feedback.html
Lines 17 to 19 in 1b46d71
I've changed the files in my local repo to resolve this issue. If you the maintainers are happy to accept a PR for this I would like to submit it. If you wanna have a look at the current state see here: tobiaskohlbau@ed57f05
The text was updated successfully, but these errors were encountered: