Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback questions: add localization #1615

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

deining
Copy link
Collaborator

@deining deining commented Jul 7, 2023

This PR adds localization to docsy's feedback feature.


/cc @tobiaskohlbau

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. See inline comments.

layouts/partials/feedback.html Outdated Show resolved Hide resolved
layouts/partials/feedback.html Outdated Show resolved Hide resolved
i18n/de.toml Outdated Show resolved Hide resolved
@chalin chalin requested a review from LisaFC July 27, 2023 18:22
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ✨

@chalin chalin merged commit ab1f1d0 into google:main Jul 27, 2023
5 checks passed
@deining deining deleted the page-helpful-i18n branch November 13, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n of page feedback
2 participants