-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default for github_branch
#439
Comments
Edit this page
button is not working with new Githubgithub_branch
Has it changed across the board, as my URLs (eg for this repo) still have |
Github aren't going to force or auto-change existing repos from So the problem then is, if we change the default if Probably a good idea to update the |
Gotcha. I can change the default in the config and maybe add a note to the relevant docs that you should check the value for your own repo. |
Hrmm. Actually I'd need to rename the master/main branch in the example sites as well if I changed it in the example's config.toml, because if you clone it/use it as a template you get the same branch names - just need to check what else I'd need to update (eg Netlify config) to go with that to avoid breaking stuff.... |
Yes I just tried out and master on the example site does no longer work at all. You provided my favorite theme. What do we have to do to use it right now? Or do you have an anticipated time when a fix is available? |
That's strange, it shouldn't break anything for existing sites (including our example site) - as @gwatts said above, the new default branch name in GitHub is only for new projects. If you have a Github repo where that branch is "main" rather than "master" and you want your GitHub links to work, you can change the https://www.docsy.dev/docs/adding-content/repository-links/#github_branch-optional |
great. I overlooked the github branch value that can be set. with that, we are back in business ... |
Please add
to config.toml at around line 114 I had previously created a pull request, but because it was not proceeded by a comment # it failed. This woudl be helpful for those that are waiting for a proper fix |
Like this? google/docsy-example#106 I'm not sure we can/should make them change the branch name as they may have other eg continuous deployment tooling pointing at "master", but I can put more detailed info in the docs including linking to the GitHub doc on the subject and their recommendations. |
Yes the comment in the toml would be sufficient in addition to maybe adding it more prominently in the makefile. |
Since Github has changed the default branch from master to main. The
Edit this page
button uses thegithub_branch
config to create the page and the default is "master". Should we consider changing it to "main"?The text was updated successfully, but these errors were encountered: