Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect renaming of master branch (various places) #916

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Mar 5, 2022

Renaming default branch from master to main (#913) result in various quirks. This PR corrects these deficiencies, e.g.:

  • Edit page links in right sidebar
  • Various other links
  • ...

Comment on lines +19 to +20
| https://agones.dev/site/ | https://github.com/googleforgames/agones/tree/main/site |
| https://googlecontainertools.github.io/kpt/ | https://github.com/GoogleContainerTools/kpt/tree/main/docs |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch to have noticed that these have updated their default branches too.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these followup changes! LGTM

@chalin
Copy link
Collaborator

chalin commented Mar 14, 2022

Hmm, I would have thought / hoped that GH would have handled the redirect for the edit links, but it seems that it doesn't. Again, thanks for this PR.

@chalin chalin merged commit 2d3d2c6 into google:main Mar 14, 2022
@deining deining deleted the master-to-main branch March 14, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants