Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed blocks as normal markdown #550

Closed
alisondy opened this issue May 10, 2021 · 5 comments · Fixed by #1009
Closed

Tabbed blocks as normal markdown #550

alisondy opened this issue May 10, 2021 · 5 comments · Fixed by #1009

Comments

@alisondy
Copy link

alisondy commented May 10, 2021

Tabbed blocks forces me to use a code block, Would be nice if there was an option for me to use a mix of normal markdown text and code blocks like in the following screenshot

image

@alisondy
Copy link
Author

whoops pressed enter too quickly

@alisondy alisondy changed the title Tab Tabbed blocks should be markdown May 10, 2021
@alisondy alisondy reopened this May 10, 2021
@alisondy alisondy changed the title Tabbed blocks should be markdown Tabbed blocks as normal markdown May 10, 2021
@LisaFC
Copy link
Collaborator

LisaFC commented May 10, 2021

@deining can you take a look? Thanks!

@alisondy
Copy link
Author

Sorry I should have included this earlier aswell! this is the code associated for making a tabbed view like pictured!
https://github.com/tektoncd/website/tree/main/layouts/shortcodes

@deining
Copy link
Collaborator

deining commented May 10, 2021

Hi Alison,

glad you find my tabbed pane shortcodes useful!

Tabbed blocks forces me to use a code block,
Would be nice if there was an option for me to use
a mix of normal markdown text and code blocks

When I started coding the shortcodes, the first version treated content as markdown (as requested from you). Later on, I changed this and decided to treat the inner content as code. Offering the opportunity to treat content either as code or as markdown makes certainly sense. One idea is to add another shortcode tab-code and let the tab shortcode treat content as markdown (or html). This might break existing use cases of the current shortcode, however, Another idea is to specify the content type as named parameter. Let me reflect on this a bit. I'll come back to your proposal, but due to other commitments, this might take a while.

@amirootyet
Copy link

A toggle between markdown and code in tabbed panes would be really nice. I also have a use case where I would love this toggle. Currently, I can only write plaintext in the tabbed panes because any markdown in there is not rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants