Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcodes for tabbed panes: improvements (allow textual content) #1009

Merged
merged 1 commit into from
May 24, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented May 13, 2022

This PR improves the shortcodes for tabbed panes:

  • tab content is not restricted to code any more, content can now be text (markdown or html), too
  • tab(s) can now be marked as disabled
  • storage of active language was improved, implementation was flaky
  • new option to turn storage of active language off (prevents auto-scrolling when switching between tabs with different content length)
  • better error handling for parameters
  • improvements and fixes
  • documentation update

This PR closes #936. It also closes #550.

@deining deining added enhancement New feature or request shortcodes Hugo shortcodes labels May 13, 2022
@deining deining requested a review from LisaFC May 13, 2022 17:38
@deining deining force-pushed the tabbed-pane-persistLang branch 5 times, most recently from a4851dc to 4528a3a Compare May 17, 2022 14:39
@LisaFC
Copy link
Collaborator

LisaFC commented May 18, 2022

Let me know when this is ready for review!

@deining
Copy link
Collaborator Author

deining commented May 18, 2022

Let me know when this is ready for review!

This PR is ready for review now, I hope you like it.

@geriom
Copy link
Collaborator

geriom commented May 21, 2022

Awesome! I was actually trying to implement this same feature because we use a similar shortcode with a different name in Tekton. I''m going to TAL.

Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Thank you!

Just a couple of small suggestions.

layouts/shortcodes/tabpane.html Outdated Show resolved Hide resolved
layouts/shortcodes/tab.html Outdated Show resolved Hide resolved
@deining deining requested a review from geriom May 23, 2022 14:17
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- allow tab content in markdown
- tab header can now be given as unnamed parameter
- tab(s) can now be disabled
- improve storage of active language
- new option to turn storage of active language off
- improvements and fixes
- documentation update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shortcodes Hugo shortcodes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown render in the tab shortcode Tabbed blocks as normal markdown
3 participants