Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Bootstrap and Font Awesome git submodules #948

Closed
3 tasks done
chalin opened this issue Mar 28, 2022 · 2 comments
Closed
3 tasks done

Eliminate Bootstrap and Font Awesome git submodules #948

chalin opened this issue Mar 28, 2022 · 2 comments
Assignees
Labels
CI/infra CI & infrastructure
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Mar 28, 2022

Tasks:

@chalin chalin added the CI/infra CI & infrastructure label Mar 28, 2022
@chalin chalin added this to the 22Q2 milestone Mar 28, 2022
@chalin
Copy link
Collaborator Author

chalin commented Mar 28, 2022

PR #889 implements this, and you can see that the site builds just fine:

@chalin
Copy link
Collaborator Author

chalin commented Mar 29, 2022

@geriom, et all. Some form of the following question was asked during one of our recent PSC meetings: what harm can result from keeping the git submodules even though they are no longer needed by Docsy.

I think that #755 (comment) offers one concrete example. Though the issue mentioned is specifically w.r.t. depth, it wouldn't be an issue if the submodules weren't there :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant