Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsy 0.4.0 migration instructions and doc updates #1074

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

@chalin chalin requested a review from LisaFC June 24, 2022 14:42

git submodule update --init --recursive
{{% /alert %}}
1. Ensure you have an up to date local copy of your site files cloned from your repo.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified this because, IMHO, we shouldn't be telling folks how to clone their own repos -- in particular because we don't know the flags that they require.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, the only reason we used to have to remind people to recurse into the submodules was because of FontAwesome and Bootstrap, we had a lot of users who cloned sites that didn't work because they were missing those submodules.

@chalin
Copy link
Collaborator Author

chalin commented Jun 24, 2022

/cc @deining @geriom

@LisaFC
Copy link
Collaborator

LisaFC commented Jun 24, 2022

This looks great! Do you want to hold off on merging or can I merge now?

@chalin
Copy link
Collaborator Author

chalin commented Jun 27, 2022

Thanks for the docs tweak and LGTM. This is ready to merge now.

@chalin chalin merged commit 8200675 into google:main Jun 27, 2022
@chalin chalin deleted the chalin-im-docsy-0.4.0-migration-2022-06-24 branch June 27, 2022 14:48
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
* Docsy 0.4.0 migration instructions and doc updates

* Also drop --recurse-submodules

* tiny fix

Co-authored-by: LisaFC <lcarey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants