feat: support gitlab page meta links #1000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
@chalin ready for a review |
smainz
added a commit
to smainz/docsy
that referenced
this pull request
May 13, 2024
Derived from github and changed issueUrl schema as in google#1000
smainz
added a commit
to smainz/docsy
that referenced
this pull request
May 14, 2024
Derived from github and changed issueUrl schema as in google#1000
smainz
added a commit
to smainz/docsy
that referenced
this pull request
May 14, 2024
Derived from github and changed issueUrl schema as in google#1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375
An alternative implementation here would be to deprecate the existing
github_fields, rename them togit_instead ofgithub_and add a 5th field ofgit_repo_typewheregithuborgitlabis supported.I chose to avoid deprecation and add the new fields, but I'm open to implementation suggestions.