Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration snippets: showing toml, yaml and json format inside tabbed pane #1035

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Jun 1, 2022

According to #951, config files will be converted to YAML soon.
In the user guide, currently config file snippets are given in TOML and front matter snippets are mostly given in YAML.
This PR introduces tabbed panes for all configuration snippets listed in the user guide. Insider these tabbed panes, TOML, YAML, and JSON versions for the snippets are presented. This PR also corrects some minor typos and grammatical errors that were found on the way.
An example of such tabbed panes can be found in the Netlify preview of this PR.

@deining deining added the user guide Improvements to user guide label Jun 1, 2022
@deining deining requested a review from LisaFC June 1, 2022 15:48
@LisaFC
Copy link
Collaborator

LisaFC commented Jun 1, 2022

This looks really good! Is it ready for merge? I've no suggested changes.

@deining
Copy link
Collaborator Author

deining commented Jun 1, 2022

This looks really good! Is it ready for merge?

Yes, it is.

@LisaFC LisaFC merged commit 6801602 into google:main Jun 1, 2022
@deining deining deleted the config_multiple_formats branch June 2, 2022 07:05
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user guide Improvements to user guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants