Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add link to migration guide #1036

Merged
merged 1 commit into from
Jun 2, 2022
Merged

fix: add link to migration guide #1036

merged 1 commit into from
Jun 2, 2022

Conversation

317brian
Copy link
Contributor

@317brian 317brian commented Jun 1, 2022

I'm not sure if I should be using the filepath or a URL. The same link to the migration guide on "Get started: Migration and backward compatibility" uses the URL

If you have an existing site that uses Docsy as a Git submodule, and you would like to update it to use Hugo Modules, follow our [migration guide](https://www.docsy.dev/docs/updating/convert-site-to-module/)

@google-cla
Copy link

google-cla bot commented Jun 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Using the filepath is a good decision.

@deining deining merged commit 936ced9 into google:main Jun 2, 2022
@deining
Copy link
Collaborator

deining commented Jun 2, 2022

Thanks for spotting and fixing this broken link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants