Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tabbed pane: allow right aligned tabs, allow tab groups #1037

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Jun 3, 2022

This PR improves and extends the shortcodes for tabbed panes:

  • the shortcodes learned to show right aligned tabs (by giving right=true on the tabpaneshortcode).
  • the shortcodes now support spllitting up tabs in a left aligned and a right aligned tab group (by giving right=true on the dividing tab shortcode(s)). If wanted, even multiple tab groups can be rendered.

The PR also contains fixes as well as css and code improvements.
The PR is ready for review and subsequent merging.

@chalin
Copy link
Collaborator

chalin commented Jul 4, 2022

Thanks @deining - can you rebase and address the build failures? Also, can you add a link to a page where we can preview the effects of the change?

@deining deining force-pushed the tab-right branch 2 times, most recently from d45edfb to 61f3c6f Compare July 6, 2022 17:37
@deining
Copy link
Collaborator Author

deining commented Jul 6, 2022

Thanks @deining - can you rebase and address the build failures?

Done and done.

Also, can you add a link to a page where we can preview the effects of the change?

Please have a look at this preview.

@deining deining requested review from chalin and removed request for LisaFC and geriom July 6, 2022 17:44
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for this update (and your patience in getting it reviewed)!

@chalin chalin merged commit 1b10f6b into google:main Jul 13, 2022
@deining deining deleted the tab-right branch August 18, 2022 11:17
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shortcodes Hugo shortcodes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants