Loading lunr.js is not critical for page rendering and can be deferred #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tekezo do you want to take this one? |
|
Thank you! I have one point of concern. - <script
+ <script defer |
|
Many thanks for the review, I've updated the PR
…On Thu, Jun 16, 2022 at 1:56 AM Takayama Fumihiko ***@***.***> wrote:
Thank you!
It's good to defer loading lunr.js.
I have one point of concern.
offline-search.js depends lunr.js, it requires lunr is ready when
DOMContentLoaded.
If the async attribute is specified, this preparation may not be completed
in time.
So, I think it's better to remove async attribute.
- <script+ <script defer
—
Reply to this email directly, view it on GitHub
<#1050 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6AU3NYQZKZNDPQTPHOYMDVPJURTANCNFSM5Y3GLBQA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
LGTM 👍 |
|
Thanks for this! |
fekete-robert
added a commit
to fekete-robert/docsy
that referenced
this pull request
Sep 13, 2022
google#1050) * Loading lunr.js is not critical for page rendering and can be deferred * Remove async to make sure lunr is available for offline-search.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.