Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Google Analytics section of UG #1098

Merged
merged 6 commits into from
Aug 6, 2022
Merged

Update Google Analytics section of UG #1098

merged 6 commits into from
Aug 6, 2022

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jul 12, 2022 •
edited
Loading

@chalin chalin added the user guide Improvements to user guide label Jul 12, 2022
This was referenced Jul 12, 2022
Closed
Closed
chalin
chalin commented Jul 12, 2022
View reviewed changes
userguide/config.toml
[services]
[services.googleAnalytics]
# Comment out the next line to disable GA tracking. Also disables the feature described in [params.ui.feedback].
id = "UA-00000000-0"
Copy link
Collaborator Author

@chalin chalin Jul 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisaFC @emckean @geriom - I suspect that the all-zeros ID is bogus, and that it was used only for the side-effect of having the feedback form appear on pages. So I'm removing this for now, and we can track progress via:

Copy link
Collaborator Author

@chalin chalin Jul 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I moved the ID to earlier in the file. It can still be used while we wait for a "real" ID (#1097).

@chalin chalin marked this pull request as draft July 12, 2022 21:06
@chalin chalin marked this pull request as ready for review July 12, 2022 21:49
@chalin
Copy link
Collaborator Author

chalin commented Jul 12, 2022

FYI, I posted this question: https://discourse.gohugo.io/t/config-is-services-googleanalytics-id-an-alias-for-googleanalytics/39469. If it turns out that they are (officially) aliases, I'll add a note to that effect to the GA section.

@chalin chalin force-pushed the chalin-mbp-ga-ug-2022-07-12 branch from 5f333ac to 4367665 Compare July 13, 2022 14:52
@chalin chalin requested review from deining and geriom July 13, 2022 15:14
@chalin chalin marked this pull request as draft July 13, 2022 15:43
@chalin chalin requested a review from deining July 15, 2022 15:28
@chalin chalin marked this pull request as ready for review July 15, 2022 15:28
@chalin
Copy link
Collaborator Author

chalin commented Jul 15, 2022

All: this is ready for review. I decided to simplify this change by referring the reader to the appropriate section of the Hugo docs. The page update includes a warning (about not setting both googleAnalytics and services.googleAnalytics.id), but eventually (once gohugoio/hugoDocs#1780 is addressed), we'll be able to remove the warning.

@chalin chalin force-pushed the chalin-mbp-ga-ug-2022-07-12 branch from 3162be6 to de7ac01 Compare July 29, 2022 18:57
@geriom geriom force-pushed the chalin-mbp-ga-ug-2022-07-12 branch from 562183d to 684394a Compare August 2, 2022 15:33
@geriom
Copy link
Collaborator

geriom commented Aug 2, 2022

but eventually (once gohugoio/hugoDocs#1780 is addressed), we'll be able to remove the warning.

Should we open an issue to track this?

@chalin chalin force-pushed the chalin-mbp-ga-ug-2022-07-12 branch from 684394a to f7ebc1f Compare August 6, 2022 09:54
@chalin chalin force-pushed the chalin-mbp-ga-ug-2022-07-12 branch from f7ebc1f to b31a73a Compare August 6, 2022 09:55
@chalin chalin mentioned this pull request Aug 6, 2022
Open
@chalin
Copy link
Collaborator Author

chalin commented Aug 6, 2022

Should we open an issue to track this?

Done:

Given @geriom's approval, I'm going to merge.

@chalin chalin merged commit 2b3b924 into google:main Aug 6, 2022
@chalin chalin deleted the chalin-mbp-ga-ug-2022-07-12 branch August 6, 2022 09:59
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
@chalin @fekete-robert
Update Google Analytics section of UG (google#1098)
089b3c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriom geriom geriom approved these changes

@deining deining Awaiting requested review from deining

Assignees

@geriom geriom

Labels
analytics user guide Improvements to user guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Understanding config params: services.googleAnalytics.id vs. top-level googleAnalytics
3 participants
@chalin @geriom @deining