Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set docsy version in config as version #1105

Merged

Conversation

@@ -85,7 +85,7 @@ archived_version = false
# The version number for the version of the docs represented in this doc set.
# Used in the "version-banner" partial to display a version number for the
# current doc set.
version = "0.0"
version = "0.4.0"
Copy link
Collaborator Author

@chalin chalin Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reusing the version config param. Seems ok in this case.

Also note that I'm leaving this as 0.4.0 since that is the latest official version.

@chalin chalin requested review from deining and geriom July 15, 2022 19:41
@chalin chalin force-pushed the chalin-mbp-docsy-vers-in-config-2022-07-15 branch from 1e19ba7 to daeb7e1 Compare July 29, 2022 18:41
@geriom geriom force-pushed the chalin-mbp-docsy-vers-in-config-2022-07-15 branch from 83b2ced to aefe29c Compare August 2, 2022 14:52
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great quality of life improvement. Thank you!

@geriom geriom merged commit 87cb556 into google:main Aug 2, 2022
@chalin chalin deleted the chalin-mbp-docsy-vers-in-config-2022-07-15 branch August 6, 2022 09:12
@chalin
Copy link
Collaborator Author

chalin commented Aug 6, 2022

Thanks @geriom!

Just a reminder to squash-merge PRs (#725) -- I get the impression that this PR wasn't squashed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants