Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UG feedback: update SEO page #1132

Merged
merged 1 commit into from
Jul 28, 2022
Merged

UG feedback: update SEO page #1132

merged 1 commit into from
Jul 28, 2022

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jul 27, 2022 •
edited
Loading

@chalin chalin added user guide Improvements to user guide cleanup/refactoring labels Jul 27, 2022
@aimeeu
Copy link
Contributor

aimeeu commented Jul 27, 2022

Please don't drop that SEO section from the User Guide. I authored the fix in #662. Docsy users should know how the value for the description meta tag is created as you wrote: page description, page summary, site description..Site.Params.description can create duplicate meta tag content across many pages, which search engines do not like. Granted the site description option is not likely to happen, but it's nice to have the order documented so users don't have to dig like I did when SEO scans come back full of issues. Thanks.

@chalin
Copy link
Collaborator Author

chalin commented Jul 27, 2022

Thanks for your feedback @aimeeu and @emckean. If you agree with the changes, could you (GitHub) approve?

@chalin chalin requested a review from LisaFC July 27, 2022 22:43
@LisaFC
Copy link
Collaborator

LisaFC commented Jul 28, 2022

LGTM!

@LisaFC LisaFC merged commit 3e2e63f into google:main Jul 28, 2022
@chalin chalin deleted the chalin-im-meta-desc-2022-07-27 branch July 28, 2022 16:51
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
@chalin @fekete-robert
UG feedback: update SEO page (google#1132)
d64d172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimeeu aimeeu aimeeu approved these changes

@LisaFC LisaFC Awaiting requested review from LisaFC

Assignees
No one assigned
Labels
cleanup/refactoring user guide Improvements to user guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update user guide following #1092 - new meta description
3 participants
@chalin @aimeeu @LisaFC