Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 layout: fix relURL argument #1134

Merged
merged 1 commit into from
Jul 28, 2022
Merged

404 layout: fix relURL argument #1134

merged 1 commit into from
Jul 28, 2022

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jul 28, 2022 •
edited
Loading

@chalin chalin requested review from LisaFC, deining and geriom July 28, 2022 00:36
@chalin chalin mentioned this pull request Jul 28, 2022
Closed
2 tasks
@chalin
Copy link
Collaborator Author

chalin commented Jul 28, 2022

/cc @Marzal

@chalin chalin marked this pull request as draft July 28, 2022 00:40
@chalin
Copy link
Collaborator Author

chalin commented Jul 28, 2022

Ah, now I see why the layout was like it was. I'll need to fix it, but that will have to wait until tomorrow.

@chalin chalin force-pushed the chalin-im-relurl-take2-2022-07-27 branch from 100c83c to 48029dc Compare July 28, 2022 18:50
@chalin chalin marked this pull request as ready for review July 28, 2022 18:51
@chalin chalin changed the title 404 layout: fix HTML and relURL argument 404 layout: fix relURL argument Jul 28, 2022
@chalin chalin force-pushed the chalin-im-relurl-take2-2022-07-27 branch from 48029dc to 8f69177 Compare July 28, 2022 18:52
@chalin
Copy link
Collaborator Author

chalin commented Jul 28, 2022

All: this simple fix is ready for review. I'm going to handle the HTML rework through another PR. Given how trivial a change this is, I'm going to merge. Feedback is always welcome.

@chalin chalin merged commit f13a2ee into google:main Jul 28, 2022
@chalin chalin deleted the chalin-im-relurl-take2-2022-07-27 branch July 28, 2022 18:54
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
@chalin @fekete-robert
404 layout: fix relURL argument (google#1134)
7606cf0
@deining deining mentioned this pull request Feb 27, 2023
Open
@renovate renovate bot mentioned this pull request Feb 17, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Apr 30, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaFC LisaFC Awaiting requested review from LisaFC

@deining deining Awaiting requested review from deining

@geriom geriom Awaiting requested review from geriom

Assignees
No one assigned
Labels
cleanup/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 layout generates invalid HTML Broken URLs since Hugo 101 due to leading slash and relURL
1 participant
@chalin