404 layout: fix HTML, avoid nested main #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
commented
Jul 28, 2022
Comment on lines
+28
to
32
| .td-main main { | ||
| padding-top: 1.5rem; | ||
| padding-bottom: 2rem; | ||
| @include media-breakpoint-up(md) { padding-top: 5.5rem; } | ||
| } |
There was a problem hiding this comment.
This change is a refactoring of the selector .td-main main so that the style definition can be reused for .td-404 main, plus the added non-media-breakpoint base style of padding-top: 1.5rem. IMHO, the result looks better if you look at the screenshots in the Conversation tab.
geriom
force-pushed
the
chalin-im-404-html-fix-2022-07-28
branch
from
c9417c3
to
5d31b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-1137--docsydocs.netlify.app/some-invalid-url/
Screenshots
Before:
After: