Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SCSS variable for FA font name #1176

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

samiahmedsiddiqui
Copy link
Contributor

@samiahmedsiddiqui samiahmedsiddiqui commented Aug 16, 2022

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@chalin
Copy link
Collaborator

chalin commented Aug 16, 2022

No change to the generated site files other than the CSS map:

$ (cd userguide/public && git diff) | grep ^diff
diff --git a/scss/main.css.map b/scss/main.css.map

I also double checked that there is but one hardcoded "Font Awesome 6 Free" string, namely the variable definition.

@chalin chalin merged commit 6df4c07 into google:main Aug 16, 2022
@samiahmedsiddiqui samiahmedsiddiqui deleted the FAFontName branch August 16, 2022 14:39
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SCSS variable for FA font name
2 participants