Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcode rendering in readfile shortcode #1203

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

geriom
Copy link
Collaborator

@geriom geriom commented Aug 29, 2022

This allows importing files that contain shortcodes themselves, and the shortcodes will be rendered correctly.

Requires Hugo v0.101.0+ to work correctly, for older versions this change has no effect on the output.

The PR docs preview shows an example

@geriom geriom force-pushed the readfile-render-shortcodes branch 2 times, most recently from f34aad6 to e3b322c Compare August 29, 2022 17:32
@geriom geriom mentioned this pull request Aug 29, 2022
6 tasks
@LisaFC LisaFC self-requested a review August 30, 2022 08:00
This allows to importing files that contain shortcodes themselves, and
the shortcodes will be rendered correctly.

Requires Hugo v0.101.0+
- Bump Alpine Hugo image version to v.101.0

- Fix the error:

```
fatal: detected dubious ownership in repository at '/github/workspace'
To add an exception for this directory, call:

   git config --global --add safe.directory /github/workspace
```
@geriom geriom merged commit 6d98771 into google:main Aug 30, 2022
@polarweasel
Copy link

@LisaFC and @geriom We're running into a problem with this new readfile shortcode: it will not correctly render Docsy's tabpanes. Was there an issue associated with this PR that we can reopen, or do you want a new one?

@geriom
Copy link
Collaborator Author

geriom commented Sep 26, 2022

@polarweasel are you still having an issue with tabpanes?

Something like this should work:

{{< tabspane >}}

{{< tab "Tab1" >}}
Tab1 text
{{< /tab >}}

{{< tab "Tab2" >}}
Tab2 Text
{{< /tab >}}

{{< tab "Tab3" >}}
Tab3 Text
{{< /tab >}}

{{< /tabpane >

If it doesn't work feel free to open a new issue and @ me there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants