Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: mermaid diagrams with parameters in site config #1316

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Fix: mermaid diagrams with parameters in site config #1316

merged 1 commit into from
Dec 1, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Nov 23, 2022 •
edited
Loading

This PR fixes this two regressions introduced with 90843e3:

  • build breaks if mermaid diagram(s) are displayed on one or more pages and parameters for mermaid are given in the site config.
  • parameters for mermaid given in the site config were picked up only if mermaid.enable=true was given. With auto-activation of mermaid diagrams in place, parameters should be considered event if mermaid.enable is missing in the site config.

This PR also bumps mermaid to the latest released version 9.2.2.

@deining deining added the regression Feature that has worked before stopped working label Nov 23, 2022
@deining deining requested a review from geriom November 23, 2022 07:54
@deining deining mentioned this pull request Nov 26, 2022
Closed
multun
multun approved these changes Nov 26, 2022
View reviewed changes
Copy link
Contributor

@multun multun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this patch fixes the regression 🎉

geriom
geriom approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and can confirm this works. Thank you!

@geriom geriom merged commit 33f3dfe into google:main Dec 1, 2022
@deining deining deleted the mermaid-regression branch December 1, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multun multun multun approved these changes

@geriom geriom geriom approved these changes

Assignees

@LisaFC LisaFC

Labels
regression Feature that has worked before stopped working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deining @multun @geriom @LisaFC