Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent navbar text wrapping #1320

Merged
merged 1 commit into from
Dec 2, 2022
Merged

prevent navbar text wrapping #1320

merged 1 commit into from
Dec 2, 2022

Conversation

multun
Copy link
Contributor

@multun multun commented Nov 25, 2022

When a navbar item has multiple words, and there are enough navbar item to cause the flexbox to be full at reduced window widths without transitioning through the lower media breakpoint, the navbar link name can wrap, which causes the alignment of all navbar items to break.

This change forbids navbar text wrapping even at bigger screen sizes.

Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@geriom
Copy link
Collaborator

geriom commented Dec 1, 2022

@multun It seems I can't push changes to your branch. Please rebase to include the latest changes from main so we can merge.

When a navbar item has multiple words, and there are enough navbar item to
cause the flexbox to be full at reduced window widths without transitioning
through the lower media breakpoint, the navbar link name can wrap, which causes
the alignment of all navbar items to break.

This change forbids navbar text wrapping even at bigger screen sizes.
@multun
Copy link
Contributor Author

multun commented Dec 2, 2022

@geriom done

@geriom geriom merged commit 1fb0e23 into google:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants